Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new checks for Plugin Header fields #786

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Add new checks for Plugin Header fields #786

wants to merge 5 commits into from
+68 −4

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 12, 2024 •
edited
Loading

Fixes #783

New error codes added:

  • plugin_header_missing_plugin_description
  • plugin_header_missing_plugin_version
  • plugin_header_invalid_plugin_version

@ernilambar ernilambar force-pushed the 783-checks-for-plugin-header-fields branch 3 times, most recently from fbca4cc to 6e4ac2e Compare November 12, 2024 08:49
@ernilambar ernilambar changed the title Add more checks for Plugin Header fields Add new checks for Plugin Header fields Nov 12, 2024
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Nov 12, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 12, 2024
@ernilambar ernilambar marked this pull request as ready for review November 12, 2024 08:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: chriscct7 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar force-pushed the 783-checks-for-plugin-header-fields branch from 6e4ac2e to 4493432 Compare November 19, 2024 05:20
@ernilambar ernilambar force-pushed the 783-checks-for-plugin-header-fields branch from c21c66d to 21755bf Compare November 27, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@chriscct7 chriscct7 chriscct7 approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@davidperezgar davidperezgar Awaiting requested review from davidperezgar davidperezgar is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Add new checks in Plugin_Header_Fields_Check
3 participants
@ernilambar @swissspidy @chriscct7